feat: add support for GetTimestamp, parse_to_date expressions
#3467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
support CometParseToDate expression
Author
|
How can I cover the expression for Spark 3.4? Related to CI/CD tests the expression doesn't have |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
GetTimestampexpression, which allows the followings,ParseToDateexpression, and thereforeto_datefunction ( Closes [Feature] Support Spark expression: parse_to_date #3093 )In order to add support
to_datespark sql function, we need first to coverGetTimestampas an intermediate expression within the query plan when call eitherParseToDate(to_datefunction).Note to maintainers
Since this is my first contribution to Apache DataFusion Comet, I may have missed some steps in the development or contribution process. Please let me know if anything is missing or needs adjustment.