fix: unignore input_file_name Spark SQL tests for native_datafusion #3458
+31
−74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The native_datafusion scan now correctly falls back to Spark's FileSourceScanExec when metadata columns (like input_file_name) are present, so the 3 input_file_name tests no longer need to be ignored. For ExtractPythonUDFsSuite, the issue was that the test's collect pattern didn't match CometNativeScanExec. Fixed by adding CometNativeScanExec to the collect and dataFilters match blocks. Closes apache#3312 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The previous commit accidentally removed the IgnoreComet.scala file creation from the diff, causing 94 compilation errors when applied to Spark 3.5.8. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
CometScanExec does not populate InputFileBlockHolder (the thread-local that Spark's FileScanRDD sets), so input_file_name(), input_file_block_start(), and input_file_block_length() return empty or default values when Comet replaces the scan. Detect these expressions in the plan and fall back to Spark's FileSourceScanExec. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
andygrove
force-pushed
the
fix/unignore-input-file-name-tests
branch
from
432c277 to
ab357d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Need to rebase once #3446 is merged