Skip to content

Conversation

@andygrove
Copy link
Member

@andygrove andygrove commented Jan 2, 2026

Which issue does this PR close?

Closes #.

Rationale for this change

It is really annoying to run Spark SQL tests and all Comet tests when modifying benchmarks.

What changes are included in this PR?

Skip PR builds and Spark SQL tests when PRs only touch benchmarks.

Add a new workflow: .github/workflows/pr_benchmark_check.yml

This lightweight workflow triggers only when benchmark files change and runs:

  • cargo fmt - Rust formatting check
  • cargo clippy - Rust linting
  • cargo check --benches - Verify benchmarks compile
  • mvnw compile test-compile - Scala compilation
  • scalafix - Scala linting

How are these changes tested?

@andygrove andygrove requested a review from comphead January 2, 2026 19:22
@codecov-commenter
Copy link

codecov-commenter commented Jan 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.55%. Comparing base (f09f8af) to head (6869f79).
⚠️ Report is 811 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3030      +/-   ##
============================================
+ Coverage     56.12%   59.55%   +3.43%     
- Complexity      976     1379     +403     
============================================
  Files           119      167      +48     
  Lines         11743    15496    +3753     
  Branches       2251     2569     +318     
============================================
+ Hits           6591     9229    +2638     
- Misses         4012     4970     +958     
- Partials       1140     1297     +157     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

- "native/core/benches/**"
- "native/spark-expr/benches/**"
- "spark/src/test/scala/org/apache/spark/sql/benchmark/**"
pull_request:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need pull_request? should just push be enough 🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure, tbh, but all of the other workflows have both push and pull_request

Copy link
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @andygrove

@andygrove andygrove merged commit 2f19551 into apache:main Jan 3, 2026
119 checks passed
@andygrove andygrove deleted the skip-ci-bench branch January 3, 2026 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants