Fix account deletion blocked by deleted project admin mappings (4.22 backport) #12611
+45
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@SURYAS1306 can you rebase on 4.20? You do not have to create a new PR. Just rebase your branch and select the new target. We will merge forwards and fixes on older branches. |
Author
|
Hi @DaanHoogland , I rebased the fix onto the 4.20 branch as requested. I couldn’t find an option to change the base branch of the existing PR, so I opened a new one instead. New PR: #12615 This targets the correct 4.20 branch and contains the same fix and test. |
Contributor
|
replaced by #12615 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport of #12607 to the 4.22 branch.
This change fixes an issue where account deletion was blocked if the account
was listed as an administrator of projects that were already removed
(
removedis not null).The fix ensures that only active projects are considered when checking
whether an account manages projects, allowing deletion when only deleted
projects are associated.
This includes the same defensive check and unit test added in the main branch.
Fixes #12601
Types of changes
Bug Severity