noVNC: support Spanish Latin American keyboard on VMware

[weizhouapache]

Description

This PR includes the following changes on top of CloudStack 4.22.0.0 release:

• Support VM deployment with keyboard "Spanish Latin American Keyboard".
• Support additional VM details for Templates from OVA on VMware.
• Support Spanish Latin American Keyboard in NoVNC console on VMware.

Usage

• Deploy VM with keyboard "Spanish Latin American Keyboard"

In the instance deployment wizard, choose "Spanish Latin American Keyboard” as keyboard

• Support additional VM details for Templates from OVA

If a VM template is registered with “Read Instance settings from OVA” set to true, users can add additional VM details beyond those loaded from the OVA file or created by CloudStack.
These settings can be configured globally or per zone.
(1)Enable Vmware additional details from OVA (it is disabled by default).

(2)To support the keyboard settings, set the value of global setting “vmware.allowed.additional.details.from.ova” “ to “keyboard”

When VM is Stopped, users can add, update or remove settings for keyboard.

If the keyboard is “Spanish Latin American” inside Guest VMs, please set the keyboard to “es-latam”.

• Support Spanish Latin American Keyboard in NoVNC console
  When user inputs the letters (upper cases and lower cases), numbers, and a list of special characters and keyboard combinations (provided by ARSAT), the correct characters should be displayed on the screen (Windows, or shell).

Please refer to https://commons.wikimedia.org/wiki/File:KB_Latin_American.svg

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[weizhouapache]

@blueorangutan package

[blueorangutan]

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[codecov]

Codecov Report

❌ Patch coverage is 21.42857% with 22 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.59%. Comparing base (71f47d6) to head (86b7ef2).
⚠️ Report is 97 commits behind head on 4.22.

Files with missing lines	Patch %	Lines
.../src/main/java/com/cloud/vm/UserVmManagerImpl.java	18.75%	11 Missing and 2 partials ⚠️
...apache/cloudstack/api/response/UserVmResponse.java	0.00%	6 Missing ⚠️
...ava/com/cloud/api/query/dao/UserVmJoinDaoImpl.java	33.33%	1 Missing and 1 partial ⚠️
...ain/java/com/cloud/api/query/QueryManagerImpl.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               4.22   #12484      +/-   ##
============================================
+ Coverage     17.56%   17.59%   +0.02%     
- Complexity    15545    15596      +51     
============================================
  Files          5909     5910       +1     
  Lines        529056   529845     +789     
  Branches      64617    64738     +121     
============================================
+ Hits          92953    93218     +265     
- Misses       425648   426131     +483     
- Partials      10455    10496      +41     

Flag	Coverage Δ
uitests	3.60% <ø> (+0.01%)	⬆️
unittests	18.66% <21.42%> (+0.02%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[blueorangutan]

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 16460

[weizhouapache]

@blueorangutan package

[blueorangutan]

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16469

[kiranchavala]

@blueorangutan test rocky8 vmware-70u3

[blueorangutan]

@kiranchavala a [SL] Trillian-Jenkins test job (rocky8 mgmt + vmware-70u3) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-15268)
Environment: vmware-70u3 (x2), zone: Advanced Networking with Mgmt server r8
Total time taken: 111098 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12484-t15268-vmware-70u3.zip
Smoke tests completed. 145 look OK, 4 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
ContextSuite context=TestClusterDRS>:setup	Error	0.00	test_cluster_drs.py
test_01_vpn_usage	Error	1.12	test_usage.py
test_01_deploy_vm_on_specific_host	Error	13.62	test_vm_deployment_planner.py
test_02_deploy_vm_on_specific_cluster	Error	3604.07	test_vm_deployment_planner.py
test_03_deploy_vm_on_specific_pod	Error	2.33	test_vm_deployment_planner.py
test_04_deploy_vm_on_host_override_pod_and_cluster	Error	2.30	test_vm_deployment_planner.py
test_05_deploy_vm_on_cluster_override_pod	Error	2.28	test_vm_deployment_planner.py
test_01_migrate_vm_strict_tags_success	Error	3606.12	test_vm_strict_host_tags.py
test_02_migrate_vm_strict_tags_failure	Error	4.75	test_vm_strict_host_tags.py
test_01_restore_vm_strict_tags_success	Error	15.97	test_vm_strict_host_tags.py
test_02_restore_vm_strict_tags_failure	Error	3604.49	test_vm_strict_host_tags.py
test_01_scale_vm_strict_tags_success	Error	18.11	test_vm_strict_host_tags.py
test_02_scale_vm_strict_tags_failure	Error	3603.41	test_vm_strict_host_tags.py
test_01_deploy_vm_on_specific_host_without_strict_tags	Error	19.96	test_vm_strict_host_tags.py
test_02_deploy_vm_on_any_host_without_strict_tags	Error	3605.87	test_vm_strict_host_tags.py
test_03_deploy_vm_on_specific_host_with_strict_tags_success	Error	3603.49	test_vm_strict_host_tags.py
test_04_deploy_vm_on_any_host_with_strict_tags_success	Error	3609.86	test_vm_strict_host_tags.py