Skip to content

Autoscale VM load balancing rules code improvements #12446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
sureshanaparti wants to merge 1 commit into
base: 4.20
Choose a base branch
from
+101 −134
Draft

Autoscale VM load balancing rules code improvements #12446

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions engine/schema/src/main/java/com/cloud/network/dao/LoadBalancerVMMapDao.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,5 +42,6 @@ public interface LoadBalancerVMMapDao extends GenericDao<LoadBalancerVMMapVO, Lo
LoadBalancerVMMapVO findByLoadBalancerIdAndVmIdVmIp(long loadBalancerId, long instanceId, String instanceIp);

void remove(long id, long instanceId, String instanceIp, Boolean revoke);

int expungeByVmList(List<Long> vmIds, Long batchSize);
}
1 change: 0 additions & 1 deletion engine/schema/src/main/java/com/cloud/network/dao/LoadBalancerVMMapDaoImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@ public void remove(long loadBalancerId, long instanceId, String instanceIp, Bool
expunge(sc);
}


@Override
public List<LoadBalancerVMMapVO> listByInstanceId(long instanceId) {
SearchCriteria<LoadBalancerVMMapVO> sc = createSearchCriteria();
Expand Down
6 changes: 3 additions & 3 deletions server/src/main/java/com/cloud/network/as/AutoScaleManagerImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2002,7 +2002,7 @@ private UserVmVO startNewVM(long vmId) {
}

private boolean assignLBruleToNewVm(long vmId, AutoScaleVmGroupVO asGroup) {
List<Long> lstVmId = new ArrayList<Long>();
List<Long> vmIds = new ArrayList<>();
long lbId = asGroup.getLoadBalancerId();

List<LoadBalancerVMMapVO> lbVmMapVos = lbVmMapDao.listByLoadBalancerId(lbId);
Expand All @@ -2015,9 +2015,9 @@ private boolean assignLBruleToNewVm(long vmId, AutoScaleVmGroupVO asGroup) {
}
}
}
lstVmId.add(new Long(vmId));
vmIds.add(new Long(vmId));
Copy link

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The explicit Long constructor call is unnecessary and deprecated. Use Long.valueOf(vmId) or simply add vmId directly since autoboxing will handle the conversion.

Suggested change
vmIds.add(new Long(vmId));
vmIds.add(vmId);

Copilot uses AI. Check for mistakes.
try {
return loadBalancingRulesService.assignToLoadBalancer(lbId, lstVmId, new HashMap<>(), true);
return loadBalancingRulesService.assignToLoadBalancer(lbId, vmIds, new HashMap<>(), true);
} catch (CloudRuntimeException ex) {
logger.warn("Caught exception: ", ex);
return false;
Expand Down
Loading
Loading