Skip to content

Conversation

@nvazquez
Copy link
Contributor

Description

This PR extends the zoneid parameter on the update APIs: updateVpcOffering, updateServiceOffering, updateDiskOffering, in a similar way to: #12431 (addressing #12399)

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@codecov
Copy link

codecov bot commented Jan 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 16.23%. Comparing base (f1f779a) to head (3917e8f).

Additional details and impacted files
@@            Coverage Diff            @@
##               4.20   #12440   +/-   ##
=========================================
  Coverage     16.23%   16.23%           
  Complexity    13381    13381           
=========================================
  Files          5657     5657           
  Lines        499024   499024           
  Branches      60562    60562           
=========================================
  Hits          81029    81029           
+ Misses       408959   408958    -1     
- Partials       9036     9037    +1     
Flag Coverage Δ
uitests 4.03% <ø> (ø)
unittests 17.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants