Fix logs mismatch between Network GC wait and interval #10776

andrijapanicsb · 2025-04-24T19:06:38Z

Logs:

2025-04-24 19:04:20,912 INFO [o.a.c.e.o.NetworkOrchestrator] (Network-Scavenger-1:ctx-34a60b9f) (logid:ab827a5e) NetworkGarbageCollector uses '121' seconds for GC interval.
^C

Actual values (with mgmt server restart done after the value changes):

codecov · 2025-04-24T19:12:56Z

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 16.26%. Comparing base (1300fc5) to head (ca8bb8e).

Files with missing lines	Patch %	Lines
...tack/engine/orchestration/NetworkOrchestrator.java	0.00%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##               4.20   #10776   +/-   ##
=========================================
  Coverage     16.26%   16.26%           
- Complexity    13420    13422    +2     
=========================================
  Files          5658     5658           
  Lines        499496   499497    +1     
  Branches      60626    60626           
=========================================
+ Hits          81234    81250   +16     
+ Misses       409214   409197   -17     
- Partials       9048     9050    +2

Flag	Coverage Δ
uitests	`4.02% <ø> (ø)`
unittests	`17.12% <0.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

engine/schema/src/main/resources/META-INF/db/schema-42000to42010.sql

nvazquez · 2025-04-25T09:43:56Z

...hestration/src/main/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java

-                logger.info("NetworkGarbageCollector uses '{}' seconds for GC interval.", netGcWait);
+                final int netGcInterval = NumbersUtil.parseInt(_configDao.getValue(NetworkGcInterval.key()), 60);
+                logger.info("NetworkGarbageCollector uses '{}' seconds for GC wait.", netGcWait);
+                logger.info("NetworkGarbageCollector uses '{}' seconds for GC interval.", netGcInterval);


Perhaps these 2 lines can be unified into a single one: NetworkGarbageCollector uses '{}' seconds for GC wait and '{}' seconds for GC interval.

engine/schema/src/main/resources/META-INF/db/schema-42000to42010.sql

Update dynamic setting for the network.gc.intervla and the wrong message for wait period.

network.gc.value was mistakenly obtained from network.gc.wait added messages for both gc.wait and gc.internval.

nvazquez · 2025-04-25T10:02:17Z

@blueorangutan package

sureshanaparti

clgtm

sonarqubecloud · 2025-04-25T10:58:44Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

...hestration/src/main/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java

weizhouapache · 2025-05-20T09:25:46Z

...hestration/src/main/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java

            "Time (in seconds) to wait before shutting down a network that's not in used", false, Scope.Global, null);
    public static final ConfigKey<Integer> NetworkGcInterval = new ConfigKey<Integer>(Integer.class, "network.gc.interval", "Advanced", "600",
-            "Seconds to wait before checking for networks to shutdown", true, Scope.Global, null);
+            "Seconds to wait before checking for networks to shutdown", false, Scope.Global, null);


good 👍

btw: NetworkGcWait can be changed to Dynamic

...hestration/src/main/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java

rajujith · 2026-01-12T09:04:29Z

@andrijapanicsb Since this is for the 4.22.1 release, could you retarget the PR to the 4.22 branch?

…e/orchestration/NetworkOrchestrator.java Co-authored-by: Wei Zhou <weizhou@apache.org>

...hestration/src/main/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java

DaanHoogland · 2026-01-28T08:26:22Z

@blueorangutan package

blueorangutan · 2026-01-28T08:28:04Z

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-01-28T09:24:42Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16582

DaanHoogland · 2026-01-28T11:54:06Z

@blueorangutan test

blueorangutan · 2026-01-28T11:56:04Z

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

sonarqubecloud · 2026-01-28T16:36:45Z

Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 40%)

See analysis details on SonarQube Cloud

blueorangutan · 2026-01-29T03:27:39Z

[SF] Trillian test result (tid-15320)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 53079 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10776-t15320-kvm-ol8.zip
Smoke tests completed. 140 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_redundant_vpc_site2site_vpn	`Failure`	439.04	test_vpc_vpn.py

boring-cyborg bot added the component:orchestration label Apr 24, 2025

sureshanaparti reviewed Apr 25, 2025

View reviewed changes

engine/schema/src/main/resources/META-INF/db/schema-42000to42010.sql Outdated Show resolved Hide resolved

nvazquez reviewed Apr 25, 2025

View reviewed changes

andrijapanicsb and others added 3 commits April 25, 2025 06:56

Update schema-42000to42010.sql

d9868cd

Update dynamic setting for the network.gc.intervla and the wrong message for wait period.

Update NetworkOrchestrator.java

9a66f93

network.gc.value was mistakenly obtained from network.gc.wait added messages for both gc.wait and gc.internval.

Address review comments

e0e9d64

nvazquez force-pushed the network-gc-wait-dynamic branch from ee5c057 to e0e9d64 Compare April 25, 2025 09:58

boring-cyborg bot added component:api component:build component:compute component:storage distro:ubuntu labels Apr 25, 2025

nvazquez changed the base branch from main to 4.20 April 25, 2025 09:58

nvazquez changed the title ~~Network gc wait dynamic~~ Fix logs mismatch between Network GC wait and interval Apr 25, 2025

Declare interval as non dynamic

9784516

Missing char

e1025a9

sureshanaparti approved these changes Apr 25, 2025

View reviewed changes

yadvr reviewed Apr 28, 2025

View reviewed changes

...hestration/src/main/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java Outdated Show resolved Hide resolved

weizhouapache reviewed May 20, 2025

View reviewed changes

...hestration/src/main/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java Outdated Show resolved Hide resolved

sureshanaparti added this to the 4.21.0 milestone Jun 5, 2025

sureshanaparti added this to Apache CloudStack 4.21.0 Jun 5, 2025

sureshanaparti moved this to In Progress in Apache CloudStack 4.21.0 Jul 14, 2025

weizhouapache modified the milestones: 4.21.0, 4.22.0 Aug 29, 2025

sureshanaparti removed this from Apache CloudStack 4.21.0 Aug 29, 2025

sureshanaparti added this to Apache CloudStack 4.22.0 Aug 29, 2025

sureshanaparti moved this to In Progress in Apache CloudStack 4.22.0 Aug 29, 2025

sureshanaparti self-assigned this Aug 29, 2025

harikrishna-patnala modified the milestones: 4.22.0, 4.22.1 Nov 12, 2025

harikrishna-patnala removed this from Apache CloudStack 4.22.0 Nov 12, 2025

rajujith added this to Apache CloudStack 4.22.1 Jan 5, 2026

sureshanaparti moved this to In Progress in Apache CloudStack 4.22.1 Jan 7, 2026

DaanHoogland removed this from Apache CloudStack 4.22.1 Jan 12, 2026

DaanHoogland modified the milestones: 4.22.1, 4.20.3 Jan 12, 2026

Update engine/orchestration/src/main/java/org/apache/cloudstack/engin…

90468ae

…e/orchestration/NetworkOrchestrator.java Co-authored-by: Wei Zhou <weizhou@apache.org>

DaanHoogland reviewed Jan 28, 2026

View reviewed changes

...hestration/src/main/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java Outdated Show resolved Hide resolved

Apply suggestions from code review

8b469f1

Merge branch '4.20' into network-gc-wait-dynamic

ca8bb8e

Fix logs mismatch between Network GC wait and interval #10776

Are you sure you want to change the base?

Fix logs mismatch between Network GC wait and interval #10776

Uh oh!

Conversation

andrijapanicsb commented Apr 24, 2025

Uh oh!

codecov bot commented Apr 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

nvazquez Apr 25, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

nvazquez commented Apr 25, 2025

Uh oh!

sureshanaparti left a comment

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Apr 25, 2025

Quality Gate passed

Uh oh!

Uh oh!

Uh oh!

weizhouapache May 20, 2025

Choose a reason for hiding this comment

Uh oh!

andrijapanicsb Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

rajujith commented Jan 12, 2026

Uh oh!

Uh oh!

DaanHoogland commented Jan 28, 2026

Uh oh!

blueorangutan commented Jan 28, 2026

Uh oh!

blueorangutan commented Jan 28, 2026

Uh oh!

DaanHoogland commented Jan 28, 2026

Uh oh!

blueorangutan commented Jan 28, 2026

Uh oh!

sonarqubecloud bot commented Jan 28, 2026

Quality Gate failed

Uh oh!

blueorangutan commented Jan 29, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

codecov bot commented Apr 24, 2025 •

edited

Loading