Skip to content

CASSANDRA-21247: Enable check_data_resurrection by default in cassandra_latest.yaml #4690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
isaacreath wants to merge 3 commits into
base: trunk
Choose a base branch
from
Open

CASSANDRA-21247: Enable check_data_resurrection by default in cassandra_latest.yaml #4690

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3382acc
CASSANDRA-21247: Enable check_data_resurrection by default in cassand…
isaacreath Mar 23, 2026
dcb337e
Ensure that disk resurrection check is disabled by default in dtest
isaacreath Apr 10, 2026
85291a1
Remove unused HashMap import
isaacreath Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGES.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
6.0-alpha2
* Enable check_data_resurrection by default in cassandra_latest.yaml (CASSANDRA-21247)
* Add tooling to repair system peers and peers_v2 if inconsistent with cluster metadata (CASSANDRA-21187)
* Fix a removed TTLed row re-appearance in a materialized view after a cursor compaction (CASSANDRA-21152)
* Rework ZSTD dictionary compression logic to create a trainer per training (CASSANDRA-21209)
Expand Down
16 changes: 8 additions & 8 deletions conf/cassandra_latest.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2453,21 +2453,21 @@ default_secondary_index_enabled: true
# It is possible to implement custom startup checks by implementing StatupCheck interface
# and placing JAR on a classpath, using SPI mechanism.
#
#startup_checks:
# Verifies correct ownership of attached locations on disk at startup. See CASSANDRA-16879 for more details.
# check_filesystem_ownership:
# enabled: false
# ownership_token: "sometoken" # (overriden by "CassandraOwnershipToken" system property)
# ownership_filename: ".cassandra_fs_ownership" # (overriden by "cassandra.fs_ownership_filename")
startup_checks:
# Enable this property to fail startup if the node is down for longer than gc_grace_seconds, to potentially
# prevent data resurrection on tables with deletes. By default, this will run against all keyspaces and tables
# except the ones specified on excluded_keyspaces and excluded_tables.
# check_data_resurrection:
# enabled: false
check_data_resurrection:
enabled: true
# file where Cassandra periodically writes the last time it was known to run
# heartbeat_file: /var/lib/cassandra/data/cassandra-heartbeat
# excluded_keyspaces: # comma separated list of keyspaces to exclude from the check
# excluded_tables: # comma separated list of keyspace.table pairs to exclude from the check
# Verifies correct ownership of attached locations on disk at startup. See CASSANDRA-16879 for more details.
# check_filesystem_ownership:
# enabled: false
# ownership_token: "sometoken" # (overriden by "CassandraOwnershipToken" system property)
# ownership_filename: ".cassandra_fs_ownership" # (overriden by "cassandra.fs_ownership_filename")

# This property indicates with what Cassandra major version the storage format will be compatible with.
#
Expand Down
4 changes: 3 additions & 1 deletion test/distributed/org/apache/cassandra/distributed/impl/InstanceConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@
import org.apache.cassandra.locator.SimpleSeedProvider;

import static org.apache.cassandra.config.CassandraRelevantProperties.DTEST_ACCORD_ENABLED;
import static org.apache.cassandra.config.StartupChecksConfiguration.ENABLED_PROPERTY;

public class InstanceConfig implements IInstanceConfig
{
Expand Down Expand Up @@ -129,7 +130,8 @@ private InstanceConfig(int num,
.set("index_summary_capacity", "50MiB")
.set("counter_cache_size", "50MiB")
.set("key_cache_size", "50MiB")
.set("commitlog_disk_access_mode", "legacy");
.set("commitlog_disk_access_mode", "legacy")
.set("startup_checks", Map.of("check_data_resurrection", Map.of(ENABLED_PROPERTY, false)));
if (CassandraRelevantProperties.DTEST_JVM_DTESTS_USE_LATEST.getBoolean())
{
// TODO: make this load latest_diff.yaml or cassandra_latest.yaml
Expand Down