-
Notifications
You must be signed in to change notification settings - Fork 135
CASSANDRA-18321 – distutils Version classes are deprecated. Use packaging.version instead #283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,7 +9,7 @@ | |
| # | ||
| # In case you want to test a patch with your own CCM branch, further to changing below CCM repo and branch name, you need to add -e flag at the beginning | ||
| # Example: -e git+https://github.com/userb/ccm.git@cassandra-17182#egg=ccm | ||
| git+https://github.com/apache/cassandra-ccm.git@cassandra-test#egg=ccm | ||
| -e git+https://github.com/dkropachev/cassandra-ccm.git@dk/move-off-distutils-version#egg=ccm | ||
| click==8.0.4 | ||
| decorator==5.1.1 | ||
| docopt==0.6.2 | ||
|
|
@@ -21,7 +21,7 @@ iniconfig==1.1.1 | |
| lxml==5.1.0 | ||
| mock==5.1.0 | ||
| netifaces==0.11.0 | ||
| packaging==21.3 | ||
| packaging<21 | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this needed ?
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. without it, won't we get clashing between |
||
| parse==1.20.1 | ||
| pluggy==1.0.0 | ||
| psutil==5.9.8 | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| from distutils.version import LooseVersion | ||
| from ccmlib.version import LooseVersion | ||
|
|
||
| import logging | ||
| import pytest | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| from distutils.version import LooseVersion | ||
| from ccmlib.version import LooseVersion | ||
|
|
||
| import os | ||
| import pytest | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand that you want cicd to pass and merge it, but wouldn't it better to point it to a branch from
git+https://github.com/apache/cassandra-ccm.git?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes.
this change is from the second
THROWAWAYcommit. it will not get merged.