Skip to content

tools/assertions: fail if exception does not match #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tchaikov wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

tools/assertions: fail if exception does not match #225

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tools/assertions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,8 @@ def _assert_exception(fun, *args, **kwargs):
fun(*args)
except expected as e:
if matching is not None:
regex = re.compile(matching)
assert regex.match(repr(e)) is None
msg = str(e)
assert re.search(matching, msg), f"Raised exception '{msg}' failed to match with '{matching}'"
except Exception as e:
raise e
else:
Expand Down