You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Let each plugin configure if the runtime dependencies should be automatically exported (when using camel run *), or not.
Target
I checked that the commit is targeting the correct branch (Camel 4 uses the main branch)
Tracking
If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).
Apache Camel coding standards and style
I checked that each commit in the pull request has a meaningful subject line and body.
I have run mvn clean install -DskipTests locally from root folder and I have committed all auto-generated changes.
🌟 Thank you for your contribution to the Apache Camel project! 🌟
🤖 CI automation will test this PR automatically.
🐫 Apache Camel Committers, please review the following items:
First-time contributors require MANUAL approval for the GitHub Actions to run
You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot although they are normally detected and executed by CI.
You can label PRs using build-all, build-dependents, skip-tests and test-dependents to fine-tune the checks executed by this PR.
Build and test logs are available in the summary page. OnlyApache Camel committers have access to the summary.
⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.
Default behavior change: The new contributeRuntimeDependencies() defaults to false, which changes the current behavior where all plugin exporters contribute their dependencies during camel run. Are there existing PluginExporter implementations that rely on this? If so, they would silently stop contributing dependencies. Was this intentional?
Test-scoped dependency filtering removed: The previous code filtered out test-scoped dependencies (!dependency.startsWith("mvn@test")). With this change, plugins that opt in via contributeRuntimeDependencies() will contribute all dependencies, including test-scoped ones. Is this intended, or should the filtering be preserved?
@gnodetAre there existing PluginExporter implementations that rely on this? No, the only one is being developed. Moreover, at the moment, camel 4.18, does not contribute automatically dependencies at all in the run scenario.
Test-scoped dependency filtering removed The purpose of this PR is to avoid handling the dependencies to exclude in the core itself, but each plugin will contribute more dependencies or not, the default to false is to avoid other plugins to update code.
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA: CAMEL-23157
Description
Target
mainbranch)Tracking
Apache Camel coding standards and style
mvn clean install -DskipTestslocally from root folder and I have committed all auto-generated changes.