(test): add test coverage for camel-rest component

[orpiske]

Summary

• Add comprehensive unit tests for the camel-rest component
• Increase code coverage from 0% to 68%
• Create 21 test files with 256 tests covering all major classes

Test Coverage

Tests cover the following classes:

• RestComponent and RestEndpoint
• RestApiComponent and RestApiEndpoint
• RestProducer and RestApiProducer
• DefaultRestRegistry and DefaultRestRegistryFactory
• RestProducerBindingProcessor and callbacks
• Component and endpoint configurers
• URI factories
• REST constants

Test plan

• All 256 tests pass
• Code compiles without errors
• Code formatted according to project standards

[github-actions]

🌟 Thank you for your contribution to the Apache Camel project! 🌟

🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

• First-time contributors require MANUAL approval for the GitHub Actions to run

• You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot.

• You can label PRs using build-all, build-dependents, skip-tests and test-dependents to fine-tune the checks executed by this PR.

• Build and test logs are available in the Summary page. Only Apache Camel committers have access to the summary.

• ⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

[squakez]

From a quick look it seems that these tests are just checking the creation of the mock, asserting that some value is initialized or not null. I don't see any business logic really tested, am I wrong?

[orpiske]

From a quick look it seems that these tests are just checking the creation of the mock, asserting that some value is initialized or not null. I don't see any business logic really tested, am I wrong?

indeed, it does seem to be leaning a bit too much on that. I'll mark this one as a draft ... I am still adjusting the spec for coverage and this one need further checks

[davsclaus]

camel-rest is tested via other components where you use it with platform-http / jetty / undertow that has rest-dsl tests.

[squakez]

camel-rest is tested via other components where you use it with platform-http / jetty / undertow that has rest-dsl tests.

Yes. We may need to see how to account aggregate report for coverage to have a more meaningful value and don't get tricked by that 0% which is not accurate. I will work on this one.

[orpiske]

I finally had some time to look at this one. There's some unnecessary tests, indeed ... but there are others that do test some of the code in this component.

Even though it might be tested somewhere, relying on test at a distance could be ... tricky for contributors to figure out what broke.

I'm going to remove the useless tests and we can keep the remaining bits.

[orpiske]

This test is unnecessary

[orpiske]

This test is unnecessary

[orpiske]

This test is unnecessary

[squakez]

FYI, with the aggregate coverage we already have 73.2% in this component. This is now available in the report. For sure, any useful test which cover the business logic here should be evaluated and kept.

[orpiske]

Another thing: this component must not depend on camel-test-junit5. It causes a cyclic dependency issue.

[orpiske]

Another thing: this component must not depend on camel-test-junit5. It causes a cyclic dependency issue.

On a side note: this one is very picky with the dependencies required. Likely to be a byproduct of https://issues.apache.org/jira/browse/CAMEL-18701, which I hope we'll fix sometime when we work on the next major.