[CALCITE-7566] Support BigQuery-style bare bracket array literals#4975
Draft
takaaki7 wants to merge 1 commit into
Draft
[CALCITE-7566] Support BigQuery-style bare bracket array literals#4975takaaki7 wants to merge 1 commit into
takaaki7 wants to merge 1 commit into
Conversation
BigQuery accepts array literals written without the ARRAY keyword, e.g. SELECT [1, 2, 3]. Calcite's parser previously rejected this form with `Encountered "[" at line 1, column 8` even under SqlConformanceEnum.BIG_QUERY. Introduce SqlConformance#allowBareBracketArrayLiteral() (true for BIG_QUERY, BABEL, LENIENT) and add a conformance-gated alternative in the JavaCC ArrayConstructor production that consumes `[ ... ]` and emits the same ARRAY_VALUE_CONSTRUCTOR call used by the existing `ARRAY[...]` syntax, so validation, type derivation, and unparse paths need no further change.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ARRAYkeyword, e.g.SELECT [1, 2, 3], when conformance isBIG_QUERY(alsoBABEL,LENIENT).SqlConformance#allowBareBracketArrayLiteral()and gates a new alternative in the JavaCCArrayConstructorproduction with it. The new alternative emits the sameARRAY_VALUE_CONSTRUCTORcall used byARRAY[...], so validation, type derivation, and unparse paths require no other changes.Test plan
SqlParserTest#testBareBracketArrayLiteralcovers[1, 2, 3], empty[], nested[[1, 2], [3, 4]], subscript[10, 20, 30][1], andSELECT [1, 2, 3]underBIG_QUERY; also assertsBABEL/LENIENTaccept andDEFAULT/STRICT_2003reject../gradlew :core:test --tests CoreSqlParserTest --tests SqlUnParserTest— 991 passed, 0 failed (9 pre-existing skips).🤖 Generated with Claude Code