Skip to content

[CALCITE-7408] Enable URL_ENCODE/URL_DECODE in ClickHouse Dialect#4784

Open
xuzifu666 wants to merge 3 commits intoapache:mainfrom
xuzifu666:ck_urlencode_support
Open

[CALCITE-7408] Enable URL_ENCODE/URL_DECODE in ClickHouse Dialect#4784
xuzifu666 wants to merge 3 commits intoapache:mainfrom
xuzifu666:ck_urlencode_support

Conversation

@xuzifu666
Copy link
Member

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 4, 2026

@michaelmior
Copy link
Member

I'm not an expert in ClickHouse, but the documentation suggests ClickHouse calls these functions encodeURLComponent and decodeURLComponent. Since we're talking about changes to the ClickHouse dialect, it would be good to match these names.

@xuzifu666
Copy link
Member Author

I'm not an expert in ClickHouse, but the documentation suggests ClickHouse calls these functions encodeURLComponent and decodeURLComponent. Since we're talking about changes to the ClickHouse dialect, it would be good to match these names.

@michaelmior Thank you for the suggestion. Here's my understanding: this PR mainly addresses two things:

  1. It enables the ClickHouse Library to recognize the url_encode and url_decode functions;

  2. It accurately converts SQL from Calcite to the correct ClickHouse dialect, as explained in the documentation, for example, converting url_encode to encodeURLComponent.

Since this name is specific to the ClickHouse dialect, it seems unnecessary to introduce a function with the same implementation but a different name. This can be seen in RelToSqlConvertTest, where the dialect-converted name is correct. I wonder if you agree with my point of view.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants