Skip to content

[CALCITE-5390] RelDecorrelator throws NullPointerException #4776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
iwanttobepowerful wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[CALCITE-5390] RelDecorrelator throws NullPointerException #4776

iwanttobepowerful wants to merge 1 commit into from
+418 −7

Conversation

@iwanttobepowerful
Copy link
Contributor

@iwanttobepowerful iwanttobepowerful commented Jan 28, 2026 •
edited
Loading

iwanttobepowerful
iwanttobepowerful commented Jan 28, 2026
View reviewed changes
@iwanttobepowerful
Copy link
Contributor Author

iwanttobepowerful commented Jan 28, 2026

I think the frameStack introduced by @suibianwanwank simulates the de Bruijn indexes mentioned by @julianhyde .

mihaibudiu
mihaibudiu reviewed Jan 28, 2026
View reviewed changes
iwanttobepowerful
iwanttobepowerful commented Jan 29, 2026
View reviewed changes
core/src/main/java/org/apache/calcite/sql2rel/RelDecorrelator.java
return map.get(r);
}

private RelNode getCorRel(CorRef corVar) {
Copy link
Contributor Author

@iwanttobepowerful iwanttobepowerful Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might be able to delete getCorRel. I found during debugging that this function is never reached anymore.

@iwanttobepowerful iwanttobepowerful force-pushed the calcite5390 branch 2 times, most recently from 8e7ac0c to 3bab8c4 Compare January 29, 2026 08:44
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 29, 2026

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
82.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

xiedeyantu
xiedeyantu reviewed Feb 4, 2026
View reviewed changes
@iwanttobepowerful
Copy link
Contributor Author

iwanttobepowerful commented Feb 6, 2026

@dssysolyatin @rubenada @mihaibudiu @NobiGo @suibianwanwank
can you help review this PR? Thx.

@iwanttobepowerful iwanttobepowerful added LGTM-will-merge-soon Overall PR looks OK. Only minor things left. labels Feb 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xiedeyantu xiedeyantu xiedeyantu left review comments

@mihaibudiu mihaibudiu mihaibudiu approved these changes

Assignees

No one assigned

Labels

LGTM-will-merge-soon Overall PR looks OK. Only minor things left.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@iwanttobepowerful @mihaibudiu @xiedeyantu