Skip to content

avoid running static initializers in CursorFactory.fromProto #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sahvx655-wq wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −1
Open

avoid running static initializers in CursorFactory.fromProto #310

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion core/src/main/java/org/apache/calcite/avatica/Meta.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -722,7 +722,10 @@ public static CursorFactory fromProto(Common.CursorFactory proto) {

if (proto.hasField(CLASS_NAME_DESCRIPTOR)) {
try {
clz = Class.forName(proto.getClassName());
// Resolve without initializing: a server parsing this from an untrusted
// client must not run the named class's static initializer.
clz = Class.forName(proto.getClassName(), false,
CursorFactory.class.getClassLoader());
} catch (ClassNotFoundException e) {
throw new RuntimeException(e);
}
Expand Down
Loading