Skip to content

Opt rdma flags #3300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
randomkang wants to merge 3 commits into
base: master
Choose a base branch
from
+15 −7
Open

Opt rdma flags #3300

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c2f5f0f
Add IBV_ACCESS_RELAXED_ORDERING for rdma reg mr
randomkang May 17, 2026
a72f880
Merge branch 'master' into opt_rdma_flags
randomkang May 17, 2026
9c2fc2f
reorg code
randomkang May 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 15 additions & 7 deletions src/brpc/rdma/rdma_helper.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ int (*IbvQueryQp)(ibv_qp*, ibv_qp_attr*, ibv_qp_attr_mask, ibv_qp_init_attr*) =
int (*IbvDestroyQp)(ibv_qp*) = NULL;
ibv_comp_channel* (*IbvCreateCompChannel)(ibv_context*) = NULL;
int (*IbvDestroyCompChannel)(ibv_comp_channel*) = NULL;
ibv_mr* (*IbvRegMr)(ibv_pd*, void*, size_t, ibv_access_flags) = NULL;
ibv_mr* (*IbvRegMr)(ibv_pd*, void*, size_t, int) = NULL;
int (*IbvDeregMr)(ibv_mr*) = NULL;
int (*IbvGetCqEvent)(ibv_comp_channel*, ibv_cq**, void**) = NULL;
void (*IbvAckCqEvents)(ibv_cq*, unsigned int) = NULL;
Expand Down Expand Up @@ -178,10 +178,14 @@ void* UserExtendBlockPool(void* region_base, size_t region_size,
uint32_t RdmaRegisterMemory(void* buf, size_t size) {
// Register the memory as callback in block_pool
// The thread-safety should be guaranteed by the caller
ibv_mr* mr = IbvRegMr(g_pd, buf, size, IBV_ACCESS_LOCAL_WRITE);
ibv_mr* mr = IbvRegMr(g_pd, buf, size, IBV_ACCESS_LOCAL_WRITE | IBV_ACCESS_RELAXED_ORDERING);
Copy link
Copy Markdown
Contributor

@yanglimingcn yanglimingcn May 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some hardware devices may not support IBV_ACCESS_RELAXED_ORDERING. Could a runtime checking mechanism be implemented?

Copy link
Copy Markdown
Contributor

@yanglimingcn yanglimingcn May 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

如果 mr = IbvRegMr(g_pd, buf, size, IBV_ACCESS_LOCAL_WRITE | IBV_ACCESS_RELAXED_ORDERING);
就执行 mr = IbvRegMr(g_pd, buf, size, IBV_ACCESS_LOCAL_WRITE);

Copy link
Copy Markdown
Contributor Author

@randomkang randomkang May 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

if (!mr) {
PLOG(ERROR) << "Fail to register memory";
return 0;
PLOG(WARNING) << "Do not support IBV_ACCESS_RELAXED_ORDERING for RDMA!!!";
mr = IbvRegMr(g_pd, buf, size, IBV_ACCESS_LOCAL_WRITE);
if (!mr) {
PLOG(ERROR) << "Fail to register memory";
return 0;
}
}
g_mrs->push_back(mr);
return mr->lkey;
Expand Down Expand Up @@ -594,10 +598,14 @@ void GlobalRdmaInitializeOrDie() {
}

uint32_t RegisterMemoryForRdma(void* buf, size_t len) {
ibv_mr* mr = IbvRegMr(g_pd, buf, len, IBV_ACCESS_LOCAL_WRITE);
ibv_mr* mr = IbvRegMr(g_pd, buf, len, IBV_ACCESS_LOCAL_WRITE |IBV_ACCESS_RELAXED_ORDERING);
if (!mr) {
PLOG(ERROR) << "Fail to register memory";
return 0;
PLOG(WARNING) << "Do not support IBV_ACCESS_RELAXED_ORDERING for RDMA!!!";
mr = IbvRegMr(g_pd, buf, len, IBV_ACCESS_LOCAL_WRITE);
if (!mr) {
PLOG(ERROR) << "Fail to register memory";
return 0;
}
}
{
BAIDU_SCOPED_LOCK(*g_user_mrs_lock);
Expand Down
Loading