Issue 4797:Prevent thread leak when BookKeeper client constructor fails#4798
Open
kroosxu wants to merge 1 commit into
Open
Issue 4797:Prevent thread leak when BookKeeper client constructor fails#4798kroosxu wants to merge 1 commit into
kroosxu wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Descriptions of the changes in this PR:
Fix #4797
Motivation
When
BookKeeper.forConfig(conf).build()fails part-way through construction(for example because
metadataServiceUripoints to an unreachable or invalidZooKeeper ensemble, or
MetadataDrivers#getClientDriver(URI)cannot resolvea driver for the configured scheme), the constructor leaks every resource it
has already allocated up to the point of failure.
Changes
In the
BookKeeperconstructor, when initialization fails after theworker pools / bookie client have been created but before the object is
fully constructed, invoke
close()on the partially-initialized instanceso that all already-allocated resources are
shut down before the exception is propagated to the caller.
Add
BookKeeperConstructorFailureTestunderbookkeeper-server/src/test/java/org/apache/bookkeeper/client/coveringthe regression:
testNoThreadLeakWhenMetadataServiceUnavailable— a single failingbuild()must not leave any client-owned thread behind.testRepeatedFailedBuildsDoNotAccumulateThreads— 20 consecutivefailing
build()calls must not accumulate threads.