Skip to content

[client] fix writeLac memory leak #4713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wenbingshen wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −0
Open

[client] fix writeLac memory leak #4713

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingWriteLacOp.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
*/
package org.apache.bookkeeper.client;

import io.netty.util.ReferenceCountUtil;
import java.util.BitSet;
import java.util.List;
import org.apache.bookkeeper.client.AsyncCallback.AddLacCallback;
Expand Down Expand Up @@ -112,6 +113,8 @@ public void writeLacComplete(int rc, long ledgerId, BookieId addr, Object ctx) {

if (receivedResponseSet.isEmpty()){
completed = true;
ReferenceCountUtil.release(toSend);
toSend = null;
cb.addLacComplete(lastSeenError, lh, ctx);
}
}
Expand Down
Loading