[improve] Enable hostname specification as a script argument for topology script#4670
Open
shustsud wants to merge 2 commits intoapache:masterfrom
Open
[improve] Enable hostname specification as a script argument for topology script#4670shustsud wants to merge 2 commits intoapache:masterfrom
shustsud wants to merge 2 commits intoapache:masterfrom
Conversation
Contributor
Author
|
rerun failure checks |
shustsud
force-pushed
the
hostname_arg_network_resolution
branch
from
de35c76 to
57602fc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, when using
ScriptBasedMappingfor network location resolution via the topology script, only IP addresses are passed to the script.In some situations it is preferable to pass hostnames instead of IPs.
This PR introduces a configuration option to enable that behavior.
Changes
networkTopologyScriptUseHostNameArgsfalsetrue,ScriptBasedMappingpasses hostnames instead of IP addresses to the topology script.CachedDNSToSwitchMappingandScriptBasedMapping.RawScriptBasedMappingto respect this setting.TestRackawareEnsemblePlacementPolicyUsingScript.testUseHostnameArgsOption