Fix CloudML TFT driver install avoiding pip ResolutionTooDeep#38986
Fix CloudML TFT driver install avoiding pip ResolutionTooDeep#38986aIbrahiim wants to merge 2 commits into
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses dependency resolution issues encountered during the setup of CloudML TFT benchmarks. By decoupling the installation process and explicitly managing driver requirements, the build configuration now avoids redundant dependency re-resolution that previously triggered 'ResolutionTooDeep' errors in the pip installer. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a new requirements file cloudml_driver_requirements.txt for CloudML TFT benchmarks and updates the Gradle task installTFTRequirements to use this file, installing tfx_bsl and tensorflow-transform with --no-deps to avoid dependency resolution issues. Feedback was provided regarding an invalid version of dill (0.4.1) specified in the requirements file, which does not exist on PyPI and would cause installation failures.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| # Driver requirements for CloudML TFT benchmarks. | ||
| # tensorflow-transform and tfx_bsl are installed separately with --no-deps in | ||
| # installTFTRequirements to avoid re-resolving apache-beam[gcp] during setup. | ||
| dill==0.4.1 |
There was a problem hiding this comment.
The version dill==0.4.1 does not exist on PyPI (the latest stable releases are in the 0.3.x series, such as 0.3.8 or 0.3.9). Additionally, Apache Beam has strict constraints on dill (typically dill>=0.3.1.1,<0.3.9 or <0.3.10 depending on the Beam version). Specifying dill==0.4.1 will cause the pip install step to fail.
Please update this to a valid version compatible with Beam's constraints, such as dill>=0.3.1.1,<0.3.10.
dill>=0.3.1.1,<0.3.10
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.