Add Flink 2.2.1 runner support#38980
Conversation
c6dca5b to
d1b0825
Compare
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces support for Apache Flink 2.2.1 within the Apache Beam ecosystem. It includes the creation of a new runner module, necessary source code migrations to address breaking API changes in Flink 2.2, and comprehensive updates to build configurations, SDK metadata, and documentation to ensure seamless integration and validation of the new Flink version. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces support for Flink 2.2 across the Beam codebase, including updating supported version lists in properties, Python, and TypeScript options, adding a global Gradle capability resolution for the org.lz4:lz4-java conflict, and creating the new runners/flink/2.2 module with overridden classes such as FlinkExecutionEnvironments and DoFnOperator. The review feedback identifies two key improvement opportunities: first, in DoFnOperator.java, the lambda within numProcessingTimeTimers() should use the local manager parameter instead of directly referencing the class field timeServiceManager; second, in FlinkExecutionEnvironments.java, a null check should be added for optionsNode in configureWebUIOptions to prevent a potential NullPointerException when parsing options.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
d1b0825 to
59b5281
Compare
|
assign set of reviewers |
|
Assigning reviewers: R: @shunping for label python. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
Thanks for the contribution. Yeah Beam is a bit behind (two minor versions) in terms of Flink support. After 2.1 in 1.17-2.0 would already have 6 versions. We'd need to clean up EOL versions (1.17, 1.18) before merging this one. |
Thanks for the context! Makes total sense on cleaning up the EOL versions first. If there an existing issue or effort for the 1.17, 1.18 cleanup, I can follow that along. |
|
Thanks for the context. Same for GCP Dataproc: https://docs.cloud.google.com/managed-spark/docs/concepts/versioning/image-release-3.0 (2.3 supports 1.17, now 3.0-RC directly jumped to 2.2 though earlier RC was on 2.0). There is no known blocker for dropping 1.17, 1.18 after #38279 gets merged. |
Add a dedicated beam-runners-flink-2.2 module targeting Apache Flink 2.2.1, as tracked in #38978.
What changed:
org.apache.flink.core.execution.CheckpointingMode, which also routes enableCheckpointing() to the non-deprecated setCheckpointingConsistencyMode() internal path
Flink 2.2 breaking changes addressed (DataStream API layer — affects Beam runner):
Flink 2.2 breaking changes that are SQL/cluster-layer only (no runner code change required):
support before upgrading
Closes #38978
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.