[yaml] add support for matchall

[derrickaw]

Fixes: #38013

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

• Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
• Update CHANGES.md with noteworthy changes.
• If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

[derrickaw]

/gemini review

[gemini-code-assist]

Code Review

This pull request adds the MatchAll transform to the Beam YAML API, allowing users to match file patterns from input PCollections. The changes include the core implementation in yaml_io.py, registration in standard_io.yaml, and new integration and unit tests. Review feedback suggests narrowing a broad try-except block to prevent masking configuration errors, converting the empty_match_treatment string to the required enum type, and handling potential null values for file timestamps to avoid TypeErrors.

[codecov]

Codecov Report

❌ Patch coverage is 84.21053% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.58%. Comparing base (9a1a4b1) to head (3502cff).
⚠️ Report is 8 commits behind head on master.

Files with missing lines	Patch %	Lines
sdks/python/apache_beam/yaml/yaml_io.py	84.21%	3 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##             master   #38512      +/-   ##
============================================
+ Coverage     57.54%   57.58%   +0.03%     
  Complexity     5329     5329              
============================================
  Files          1398     1400       +2     
  Lines        198769   198943     +174     
  Branches       4980     4980              
============================================
+ Hits         114389   114555     +166     
- Misses        80466    80474       +8     
  Partials       3914     3914              

Flag	Coverage Δ
python	79.88% <84.21%> (+0.03%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces the 'MatchAll' transform to the Apache Beam YAML SDK. This addition enables users to dynamically match files based on patterns provided in the input PCollection, enhancing the file handling capabilities within YAML pipelines. The implementation includes robust schema validation and flexible configuration options for empty match scenarios.

Highlights

• New MatchAll Transform: Added a new 'MatchAll' transform to the Beam YAML API, allowing users to match file patterns within their pipelines.
• Configuration Support: Implemented support for specifying the file pattern field and handling empty matches via the 'empty_match_treatment' configuration.
• Testing: Added comprehensive unit tests and a new YAML test file to verify the functionality and error handling of the MatchAll transform.

New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces the MatchAll transform to the Beam YAML IO collection, allowing users to match file patterns provided via an input PCollection. The implementation includes logic to automatically identify the file pattern field in schema-aware PCollections and provides configuration for empty match treatment. Comprehensive integration and unit tests have been added. The review feedback correctly identifies a missing mock import in the test file which would lead to a NameError during execution.