Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new example to the Apache Beam Java SDK codebase. The purpose of this addition is to provide a reference implementation for users who need to apply rate limiting to streaming data pipelines reading from Google Cloud Pub/Sub, specifically leveraging an external Envoy Rate Limit Service. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
Assigning reviewers: R: @chamikaramj for label java. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #37992 +/- ##
=========================================
Coverage 57.34% 57.34%
Complexity 5115 5115
=========================================
Files 1392 1392
Lines 197103 197103
Branches 4817 4817
=========================================
Hits 113020 113020
Misses 80247 80247
Partials 3836 3836 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Adding new Streaming RateLimiter example
To run this on Dataflow use the below command
./gradlew :examples:java:exec -DmainClass=org.apache.beam.examples.RateLimitedPubSubReader -Dexec.args="--runner=DataflowRunner --project=apache-beam-testing --region=us-central1 --tempLocation=gs://taxi_rides_test/temp --stagingLocation=gs://taxi_rides_test/staging --jobName=tarun-test-ratelimiter-pubsub --sdkContainerImage=gcr.io/apache-beam-testing/beam-sdk/beam_java11_sdk:latest --subnetwork=regions/us-central1/subnetworks/private-subnet --rateLimiterAddress=<IP>:8081 --rateLimiterDomain=mongo_cps --topic=projects/pubsub-public-data/topics/taxirides-realtime --streaming --experiments=use_runner_v2"GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.