Skip to content

Conversation

@Amar3tto
Copy link
Collaborator

Fixes #36622


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @Amar3tto, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the website build process by optimizing how performance-related images are handled. Instead of fetching these images directly from Google Cloud Storage during page load, they are now downloaded and stored locally as static assets during the website build. This change aims to improve the overall performance and reliability of the website by reducing external dependencies at runtime and leveraging local asset serving.

Highlights

  • Performance Image Download Task: A new Gradle task, downloadPerformanceLooks, has been introduced to synchronize performance-related images from a Google Cloud Storage (GCS) bucket (gs://public_looker_explores_us_a3853f40) into the local Docker build environment. This task includes logic to check for updates using gsutil rsync -n and only downloads if changes are detected, preventing unnecessary transfers.
  • Website Build Process Integration: The main website build task now dependsOn the downloadPerformanceLooks task, ensuring that the latest performance images are available locally before the website is built. This shifts the image fetching from runtime to build time.
  • Local Static Asset Referencing: The performance_looks.html shortcode has been updated to reference performance images from a local static path (/images/performance/looks) instead of directly linking to GCS. This change improves website loading performance by serving assets locally.
  • Configuration Update: The website/www/site/data/performance.yaml file now includes a static_base field to define the base URL for these locally served performance images, providing a configurable path for the static assets.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • website/build.gradle
    • Added downloadPerformanceLooks Gradle task to sync performance images from GCS.
    • Integrated downloadPerformanceLooks as a dependency for website build tasks.
  • website/www/site/data/performance.yaml
    • Introduced static_base field to specify the local path for performance images.
  • website/www/site/layouts/shortcodes/performance_looks.html
    • Modified image src attributes to use local static paths instead of direct GCS links.
    • Added loading="lazy" attribute to image tags for deferred loading.
Activity
  • The pull request description includes standard contribution guidelines and automated CI status checks for Python, Java, and Go tests on the master branch. No specific human comments or reviews are noted in the provided context.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@Amar3tto Amar3tto requested a review from damccorm February 10, 2026 13:03
@github-actions
Copy link
Contributor

Assigning reviewers:

R: @kennknowles for label website.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@Abacn
Copy link
Contributor

Abacn commented Feb 10, 2026

The staged website doesn't show pictures:

image

https://apache-beam-website-pull-requests.storage.googleapis.com/37559/performance/textio/index.html

<Error>
<Code>NoSuchKey</Code>
<Message>The specified key does not exist.</Message>
<Details>No such object: apache-beam-website-pull-requests/37559/images/performance/looks/34/SsfFgvwyMthnHjdRwBjWGNbvfNgym4wb.png</Details>
</Error>

should

@Amar3tto Amar3tto force-pushed the download-looks branch 6 times, most recently from 84f073c to 9c474fd Compare February 10, 2026 20:14
@github-actions github-actions bot added build and removed build labels Feb 10, 2026
@Amar3tto
Copy link
Collaborator Author

The staged website doesn't show pictures:

image https://apache-beam-website-pull-requests.storage.googleapis.com/37559/performance/textio/index.html
<Error>
<Code>NoSuchKey</Code>
<Message>The specified key does not exist.</Message>
<Details>No such object: apache-beam-website-pull-requests/37559/images/performance/looks/34/SsfFgvwyMthnHjdRwBjWGNbvfNgym4wb.png</Details>
</Error>

should

Yep, there is gcs permissions issue inside the docker container, I will fix it

@Abacn
Copy link
Contributor

Abacn commented Feb 10, 2026

Alternatively we can download the images outside the docker, using Gradle tasks. Because self-hosted runner has gcp credential ang gcloud CLI, it might be an easier approach

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The Content-Security-Policy header must not be overridden

2 participants