Skip to content

Conversation

@userzhy
Copy link

@userzhy userzhy commented Dec 24, 2025

This change adds the logger name (record.name) to the custom_data field of LogEntry protos in FnApiLogRecordHandler. This is useful for filtering and debugging logs in complex pipelines.

Changes:

  • Modified FnApiLogRecordHandler.emit() to include the logger name in custom_data['logger'].
  • Added unit test test_logger_name_in_custom_data to verify the functionality.

Example:
When a log is emitted from a logger named my_module.submodule, the LogEntry.custom_data will contain:

fields {
  key: "logger"
  value {
    string_value: "my_module.submodule"
  }
}

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

Fixes #37146

This change adds the logger name (record.name) to the custom_data field
of LogEntry protos in FnApiLogRecordHandler. This is useful for filtering
and debugging logs in complex pipelines.

Fixes apache#37146
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @userzhy, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a valuable enhancement to the logging mechanism within Apache Beam's Python SDK. By embedding the logger's name directly into log entries, it significantly improves the ability to filter, analyze, and debug logs, especially in complex pipeline environments where distinguishing log sources is crucial for operational insights.

Highlights

  • Enhanced Logging: The FnApiLogRecordHandler now includes the logger's name in the custom_data field of LogEntry protos, improving log filtering and debugging capabilities.
  • Test Coverage: A new unit test, test_logger_name_in_custom_data, has been added to verify that the logger name is correctly included in the custom data.
  • Changelog Update: The CHANGES.md file has been updated to reflect the addition of the logger name to FnApiLogRecordHandler log entries.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions
Copy link
Contributor

Assigning reviewers:

R: @jrmccluskey for label python.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Include logger name in FnApiLogRecordHandler log entries

1 participant