Skip to content

Conversation

@tarun-google
Copy link
Contributor

Adding envoy-data-plane dependency to unblock #37135 PR

Notes:
1.envoy-data-plane pulls in additional dependencies. So, could not add manually
2. This PR is generated by github Action from my fork https://github.com/tarun-google/beam/actions/runs/20414662598

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @tarun-google, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates the envoy-data-plane dependency into the project's Python environment. This addition is crucial for enabling functionality developed in a separate, dependent PR. The change involved carefully updating dependency lists for different Python versions and environments (base, ML, GPU) to ensure compatibility and prevent conflicts, particularly with grpcio versions.

Highlights

  • New Dependency Added: The envoy-data-plane dependency has been introduced across various Python requirements.txt files and setup.py to unblock a related pull request (Support for EnvoyRateLimiter in Beam Python SDK #37135).
  • Conditional Dependency Versioning: The envoy-data-plane dependency is conditionally added in setup.py with version 1.0.3 for Python 3.13+ and 0.8.1 for Python versions less than 3.13, to manage compatibility with grpcio.
  • Extensive Dependency Updates: Numerous other Python package dependencies, including Google Cloud client libraries, OpenTelemetry components, and general utilities, have been updated to their latest versions across all affected requirements.txt files.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@tarun-google
Copy link
Contributor Author

Run Python_ML PreCommit 3.11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant