Skip to content

Conversation

@scwhittle
Copy link
Contributor

Clearing the side-input in finish_bundle is a balance that allows refreshing the input in streaming while not affecting performance as much. However this requires the sdk state_cache to be enabled to avoid repeated lookups to the runner.
I was originally trying to optimize the code other ways but most of the overhead appears to be due to cython/Python interactions so the fast-path cache for repeated process invocations is important.

Improve the map_fn test by using common utilities.
Add support to benchmarks to add profiling.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

- add fixed window test
- add side input tests
- improve by using benchmark helpers
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @scwhittle, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing the performance and observability of Apache Beam pipelines, particularly concerning side input handling and microbenchmarking. It introduces a refined caching strategy for side inputs within the DoFnInvoker to ensure data freshness in streaming while maintaining efficiency. Concurrently, the PR expands the microbenchmark suite with new tests for map_fn transformations involving side inputs and integrates profiling capabilities, providing better tools for performance measurement and optimization.

Highlights

  • Side Input Cache Management: The PerWindowInvoker now explicitly clears cached side input arguments at the end of each bundle via a new invoke_finish_bundle method. This change allows side inputs to be refreshed in streaming pipelines without impacting performance, provided the SDK state cache is enabled.
  • Refactored Caching Logic: The internal caching mechanism within PerWindowInvoker has been refactored, replacing boolean flags like recalculate_window_args and has_cached_window_args with dedicated should_cache_args and explicit cached_args_for_process/cached_kwargs_for_process variables for clearer state management.
  • New Microbenchmarks for map_fn with Side Inputs: Added new microbenchmarks specifically designed to measure the performance of map_fn operations, including scenarios with global and fixed-windowed side inputs, and an uncached global side input scenario for comparison.
  • RuntimeValueProvider Experiment Propagation: Ensured that RuntimeValueProvider correctly receives and propagates experiment flags from pipeline options in both DirectRunner and FnApiRunner contexts.
  • Profiling Support in Benchmarks: The microbenchmark utility (apache_beam.tools.utils) now includes support for cProfile, allowing users to generate and dump profiling statistics during benchmark runs for detailed performance analysis.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant