Skip to content

Conversation

@Amar3tto
Copy link
Collaborator

@Amar3tto Amar3tto commented Dec 8, 2025

Tests run on GHA should be queued shortly.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @Amar3tto, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a temporary, non-mergeable change to facilitate the testing of PostCommit and PreCommit test suites against a release branch. It adds an empty JSON file, release/trigger_all_tests.json, which is expected to act as a trigger for GitHub Actions (GHA) to queue and execute these tests.

Highlights

  • New Configuration File: Introduced release/trigger_all_tests.json, an empty JSON file, likely intended as a trigger or placeholder for CI/CD test configurations.
  • Test Execution Strategy: This pull request is a "DO NOT MERGE" placeholder, designed to experiment with running all PostCommit and PreCommit tests specifically against a release branch.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions github-actions bot added the build label Dec 8, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2025

Test Results

12 files  +    8  12 suites  +8   1h 45m 33s ⏱️ + 1h 25m 10s
15 tests  - 2 265  15 ✅  - 1 563  0 💤  -   702  0 ❌ ±0 
15 runs   - 4 547  15 ✅  - 2 847  0 💤  - 1 700  0 ❌ ±0 

Results for commit 31283f6. ± Comparison against base commit 2efedfd.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2025

Assigning reviewers:

R: @liferoad for label build.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@shunping
Copy link
Collaborator

shunping commented Dec 9, 2025

The "too-many-pings" issue is another grpc issue that causes flaky tests (e.g. in workflow https://github.com/apache/beam/blob/31283f67d5bb9ea033782775dfcebccb18ef3bae/.github/workflows/beam_PreCommit_Python.yml). We may have to cherry pick #37013 and #37021.

@shunping
Copy link
Collaborator

shunping commented Dec 9, 2025

@damccorm
Copy link
Contributor

damccorm commented Dec 9, 2025

Looking at failures:

AIs:

@Amar3tto
Copy link
Collaborator Author

Amar3tto commented Dec 9, 2025

Looking at failures:

AIs:

I think this is expected, because it was fixed as part of BOM upgrade. Please check my comment:
#36919 (comment)

@shunping
Copy link
Collaborator

shunping commented Dec 9, 2025

@shunping please follow go/beam-release#during-release to publish Dataflow containers

ACK. Working on this right now.

@damccorm
Copy link
Contributor

damccorm commented Dec 9, 2025

Looking at failures:

AIs:

I think this is expected, because it was fixed as part of BOM upgrade. Please check my comment: #36919 (comment)

I see - specifically the changes to FakeDatasetService.java are what fixed this. I think it is fine then, and we should be unblocked once Dataflow containers are published

@shunping
Copy link
Collaborator

shunping commented Dec 9, 2025

@shunping please follow go/beam-release#during-release to publish Dataflow containers

ACK. Working on this right now.

The dataflow containers for rc2 should be all in place now. Please let me know if you see any problems. @damccorm @Amar3tto

@Amar3tto
Copy link
Collaborator Author

@shunping please follow go/beam-release#during-release to publish Dataflow containers

ACK. Working on this right now.

The dataflow containers for rc2 should be all in place now. Please let me know if you see any problems. @damccorm @Amar3tto

Thanks,
All passed

@Amar3tto Amar3tto closed this Dec 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants