-
Notifications
You must be signed in to change notification settings - Fork 4.5k
[DO NOT MERGE] Run all PostCommit and PreCommit Tests against Release Branch #37050
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @Amar3tto, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a temporary, non-mergeable change to facilitate the testing of PostCommit and PreCommit test suites against a release branch. It adds an empty JSON file, Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Assigning reviewers: R: @liferoad for label build. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
The "too-many-pings" issue is another grpc issue that causes flaky tests (e.g. in workflow https://github.com/apache/beam/blob/31283f67d5bb9ea033782775dfcebccb18ef3bae/.github/workflows/beam_PreCommit_Python.yml). We may have to cherry pick #37013 and #37021. |
|
The workflow https://github.com/apache/beam/blob/31283f67d5bb9ea033782775dfcebccb18ef3bae/.github/workflows/beam_PostCommit_Python_ValidatesContainer_Dataflow.yml failed due to the old github runner version is in use (2.318.0) |
|
Looking at failures:
AIs:
|
I think this is expected, because it was fixed as part of BOM upgrade. Please check my comment: |
ACK. Working on this right now. |
I see - specifically the changes to |
Tests run on GHA should be queued shortly.