Skip to content

Conversation

@NayanMathur411
Copy link
Contributor

Fixes #36847

This fixes race condition occured in requirements cache creation when starting multiple pipelines together.

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

multiple pipelines concurrently (fixes apache#36847)
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @NayanMathur411, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical race condition within the Apache Beam Python SDK that previously arose when multiple pipelines attempted to create the same requirements cache directory concurrently. The core change involves making the directory creation operation robust against simultaneous calls, thereby preventing potential errors and ensuring smooth operation in parallel environments. A comprehensive new test has been added to validate the fix under simulated concurrent conditions.

Highlights

  • Race Condition Fix: Resolved a race condition that occurred during the creation of the requirements cache when multiple pipelines were started simultaneously, by ensuring the directory creation is idempotent.
  • Idempotent Directory Creation: The os.makedirs call for the requirements cache path now includes exist_ok=True, preventing errors if the directory already exists due to concurrent operations.
  • Concurrency Test Added: A new test case, test_requirements_cache_creation_no_race_condition, has been introduced to simulate concurrent cache directory creation and verify that the fix correctly handles these scenarios without failure.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@NayanMathur411
Copy link
Contributor Author

R: @hjtran

@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2025

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@hjtran
Copy link
Contributor

hjtran commented Dec 8, 2025

I'm going to defer to someone else here.

@hjtran
Copy link
Contributor

hjtran commented Dec 8, 2025

assign set of reviewers

@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2025

Assigning reviewers:

R: @tvalentyn for label python.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@codecov
Copy link

codecov bot commented Dec 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.04%. Comparing base (c6fc698) to head (ce12752).
⚠️ Report is 32 commits behind head on master.

Additional details and impacted files
@@              Coverage Diff              @@
##             master   #37042       +/-   ##
=============================================
+ Coverage     40.37%   57.04%   +16.67%     
  Complexity     3476     3476               
=============================================
  Files          1226     1226               
  Lines        188407   188602      +195     
  Branches       3607     3607               
=============================================
+ Hits          76063   107593    +31530     
+ Misses       108946    77610    -31336     
- Partials       3398     3399        +1     
Flag Coverage Δ
python 80.76% <100.00%> (+40.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tvalentyn tvalentyn merged commit 0275086 into apache:master Dec 9, 2025
94 of 101 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] [python]: Possible race condition when starting many pipelines at the same time

3 participants