-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Skip spannerio tests that depend on emulator on dataflowrunner #37018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @claudevdm, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a crucial change to the testing infrastructure by adding logic to skip Spanner emulator-dependent integration tests when they are executed on the DataflowRunner. This modification is necessary because the Spanner emulator is not compatible with the DataflowRunner environment, which previously led to irrelevant or failing test runs. By implementing this conditional skip, the PR aims to improve the overall reliability and efficiency of the continuous integration process for Apache Beam's Python SDK. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
1982b6f to
06b82a3
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #37018 +/- ##
============================================
- Coverage 40.38% 40.37% -0.02%
Complexity 3476 3476
============================================
Files 1226 1226
Lines 188339 188407 +68
Branches 3607 3607
============================================
+ Hits 76058 76063 +5
- Misses 108883 108946 +63
Partials 3398 3398
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
b0c413e to
c6fc698
Compare
|
R: @Abacn |
|
Confirmed the xlang gcp test passes in an earlier run. |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
|
@Abacn Should we cherrypick this? |
|
If RC has not yet tagged we can cherry pick. It's test config issue so non-blocking. |
Cherrypick #37018 to release-2.70
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.