Skip to content

Conversation

@claudevdm
Copy link
Collaborator

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @claudevdm, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a crucial change to the testing infrastructure by adding logic to skip Spanner emulator-dependent integration tests when they are executed on the DataflowRunner. This modification is necessary because the Spanner emulator is not compatible with the DataflowRunner environment, which previously led to irrelevant or failing test runs. By implementing this conditional skip, the PR aims to improve the overall reliability and efficiency of the continuous integration process for Apache Beam's Python SDK.

Highlights

  • Test Skipping Logic: Implemented conditional test skipping for Spanner emulator-dependent integration tests when running on the DataflowRunner, addressing incompatibility issues.
  • CI Trigger Updates: Incremented modification counters in two GitHub trigger files to re-initiate CI builds for Python Xlang GCP Dataflow and Direct pipelines.
  • Improved Test Stability: Enhanced the stability and relevance of test runs by preventing incompatible tests from executing on the DataflowRunner.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@codecov
Copy link

codecov bot commented Dec 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 40.37%. Comparing base (c0a5895) to head (c6fc698).
⚠️ Report is 19 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #37018      +/-   ##
============================================
- Coverage     40.38%   40.37%   -0.02%     
  Complexity     3476     3476              
============================================
  Files          1226     1226              
  Lines        188339   188407      +68     
  Branches       3607     3607              
============================================
+ Hits          76058    76063       +5     
- Misses       108883   108946      +63     
  Partials       3398     3398              
Flag Coverage Δ
python 40.62% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@claudevdm claudevdm marked this pull request as ready for review December 7, 2025 21:28
@claudevdm
Copy link
Collaborator Author

R: @Abacn

@claudevdm
Copy link
Collaborator Author

Confirmed the xlang gcp test passes in an earlier run.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2025

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@claudevdm claudevdm merged commit 32345e7 into apache:master Dec 8, 2025
102 of 103 checks passed
@Amar3tto
Copy link
Collaborator

Amar3tto commented Dec 8, 2025

@Abacn Should we cherrypick this?

@Abacn
Copy link
Contributor

Abacn commented Dec 8, 2025

If RC has not yet tagged we can cherry pick. It's test config issue so non-blocking.

Amar3tto added a commit that referenced this pull request Dec 8, 2025
Amar3tto added a commit that referenced this pull request Dec 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants