Skip to content

Conversation

@shunping
Copy link
Collaborator

@shunping shunping commented Dec 5, 2025

No description provided.

Amar3tto and others added 14 commits November 26, 2025 16:10
…pache#36916)

* fix retry scenario for query to table materialization

* fix retry scenario for query to table materialization
* split hdfs into extra (apache#36773)

* split hdfs into extra

* CHANGES

* tox

* try/catch

* test fixes

* add to coverage tasks

* Update CHANGES to mention extras changes (apache#36875)
* Test docker config to fix workflow.

* enable buildx and load in python docker.

* Another attempt by setting buildx project property.

* Another attempt

* Re-enable workflow and sickbay some failed tests for now.

* Add release trigger
[Cherrypick] Re-enable "PostCommit XVR GoUsingJava Dataflow" in cron (apache#36909)
* Add new method of generating key for GBEK

* Java version

* fix deps

* Imports

* Secret parsing tests

* docs

* more docs

* formatting + test cleanup

* lint

* lint

* lint

* lint

* import order

* Deps + style exemption

* reuse key:

* reuse key

* Feedback

* Test fixes
Co-authored-by: Shunping Huang <shunping@google.com>
* Update spanner client version.

* Edit comments with a new issue id.
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @shunping, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates two key updates into the Release-2.70 branch. It refactors Python dependencies by moving several packages into optional extras, promoting a more modular installation experience. Concurrently, it introduces the GcpHsmGeneratedSecret utility, a significant security enhancement that allows Beam pipelines to generate and manage secrets using Google Cloud KMS Hardware Security Modules (HSM) and Secret Manager. Additionally, the PR includes a refinement to BigQueryIO's retry mechanism for temporary tables and temporary exclusions for certain Go SDK integration tests.

Highlights

  • Python Dependency Refactoring: Several Python dependencies, including hdfs, have been moved from the core apache-beam package into optional extras. Users who rely on these components will now need to explicitly install them, for example, by using pip install apache-beam[hadoop].
  • GCP HSM Generated Secret Integration: A new GcpHsmGeneratedSecret utility has been introduced in both Java and Python SDKs. This feature enables secure generation and management of secrets leveraging Google Cloud Key Management Service (KMS) Hardware Security Modules (HSM) and Google Cloud Secret Manager.
  • BigQueryIO Retry Logic Improvement: A fix has been implemented in BigQueryIO to correctly handle and remove temporary tables during retry operations, ensuring data consistency and preventing potential issues.
Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/beam_PostCommit_XVR_GoUsingJava_Dataflow.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@shunping shunping restored the cp-spanner-fix branch December 5, 2025 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants