Skip to content

[OpenTelemetry] Add traceparent and tracestate #36963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kennknowles merged 1 commit into from
Dec 5, 2025
Merged

[OpenTelemetry] Add traceparent and tracestate #36963

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions model/fn-execution/src/main/proto/org/apache/beam/model/fn_execution/v1/beam_fn_api.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -761,6 +761,15 @@ message Elements {
// extensible and backward compatible
message ElementMetadata {
optional DrainMode.Enum drain = 1;
// (Optional) As part of https://www.w3.org/TR/trace-context/ we are forwarding a trace and participating in it.
// Traceparent header represents the incoming request in a tracing system in a common format.
// Example value: 00-0af7651916cd43dd8448eb211c80319c-b7ad6b7169203331-01
optional string traceparent = 2;
Copy link
Contributor

@scwhittle scwhittle Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can some comments be added on what they are and/or link to doc? I'm guessing parent is some id? but what is trace state? Should it be an enum? Should either of these be bytes?

Copy link
Contributor Author

@stankiewicz stankiewicz Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the feedback. It've linked to the doc and added the comment and example

// (Optional) tracestate extends traceparent with open telemetry data represented by a set of name/value pairs.
// Format specified https://www.w3.org/TR/trace-context/#list for interoperability and commonly used
// across IOs - Kafka, PubSub, http.
// Example value: congo=t61rcWkgMzE
optional string tracestate = 3;
}

// Represent the encoded user timer for a given instruction, transform and
Expand Down
Loading