Skip to content

Conversation

@Amar3tto
Copy link
Collaborator

@Amar3tto Amar3tto commented Dec 1, 2025

Fixes #33834


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@Amar3tto Amar3tto marked this pull request as ready for review December 2, 2025 08:06
@Amar3tto Amar3tto requested a review from Abacn December 2, 2025 08:06
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2025

Assigning reviewers:

R: @damccorm for label python.
R: @liferoad for label build.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

nvidia-nvjitlink-cu12:
license: "https://raw.githubusercontent.com/NVIDIA/cccl/refs/heads/main/LICENSE"
nvidia-nvtx-cu12:
license: "https://raw.githubusercontent.com/NVIDIA/cccl/refs/heads/main/LICENSE"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need these? If we're pulling in NVIDIA licenses at any point, something has gone wrong since all released artifacts need to be Apache license compliant

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gpu_image_requirements.txt contains nvidia deps and there is the error:

RuntimeError: Could not retrieve licences for packages ['nvidia-cublas-cu12', 'nvidia-cuda-cupti-cu12', 'nvidia-cuda-nvrtc-cu12', 'nvidia-cuda-runtime-cu12', 'nvidia-cudnn-cu12', 'nvidia-cufft-cu12', 'nvidia-cufile-cu12', 'nvidia-curand-cu12', 'nvidia-cusolver-cu12', 'nvidia-cusparse-cu12', 'nvidia-nccl-cu12', 'nvidia-nvjitlink-cu12', 'nvidia-nvtx-cu12', 'tokenizers', 'triton'] in Python3.12 environment. 20.19 These licenses were not able to be pulled automatically. Please search code source of the dependencies on the internet and add urls to RAW license file at sdks/python/container/license_scripts/dep_urls_py.yaml for each missing license and rerun the test.

How should we proceed?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where are we using gpu_image_requirements.txt? Right now, we should just be pushing the requirements file, not using it beyond that.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, it's because the release-2.69.0-postrelease branch had nvidia requirements in base_image_requirements.txt. And by default the workflow is running against that branch.
I updated the PR, I think it should be enough to fix the workflow, please review.

Where are we using gpu_image_requirements.txt? Right now, we should just be pushing the requirements file, not using it beyond that.

@Amar3tto Amar3tto requested a review from damccorm December 2, 2025 20:23
Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Amar3tto Amar3tto merged commit 5cd9829 into master Dec 3, 2025
128 of 132 checks passed
@Amar3tto Amar3tto deleted the fix-push-images branch December 11, 2025 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The Republish Released Docker Images job is flaky

2 participants