Skip to content

Conversation

@shunping
Copy link
Collaborator

@shunping shunping commented Dec 1, 2025

There is a breaking change coming to scikit-learn v1.8.0 (e.g. rc1) which leads to some ML test failures.

Here we set the upper bound of it to fix the test and unblock the release.

See #36936, #31285

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @shunping, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses potential test failures and compatibility issues by proactively setting an upper version constraint for the scikit-learn dependency. This ensures that the project avoids breaking changes introduced in scikit-learn version 1.8.0 and later, maintaining stability and preventing disruptions in the build and test pipelines.

Highlights

  • Scikit-learn Dependency: An upper version bound of "<1.8.0" has been added to the scikit-learn dependency in setup.py to prevent compatibility issues with upcoming breaking changes.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions github-actions bot added the python label Dec 1, 2025
@shunping
Copy link
Collaborator Author

shunping commented Dec 1, 2025

r: @damccorm @Abacn
cc: @Amar3tto

@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2025

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@shunping shunping requested review from Abacn and damccorm December 1, 2025 16:40
@Abacn
Copy link
Contributor

Abacn commented Dec 1, 2025

************* Module apache_beam.coders.coders_property_based_test
Command exited with non-zero status 4
614.19user 20.99system 1:20.70elapsed 787%CPU (0avgtext+0avgdata 853256maxresident)k
13200inputs+2504outputs (17major+1740758minor)pagefaults 0swaps
apache_beam/coders/coders_property_based_test.py:132:4: W0101: Unreachable code (unreachable)
apache_beam/coders/coders_property_based_test.py:133:4: W0101: Unreachable code (unreachable)
apache_beam/coders/coders_property_based_test.py:136:4: W0101: Unreachable code (unreachable)

not related to this change, and the file last modified 1 month ago. Not sure why it surfaced for this PR run

@shunping
Copy link
Collaborator Author

shunping commented Dec 1, 2025

************* Module apache_beam.coders.coders_property_based_test
Command exited with non-zero status 4
614.19user 20.99system 1:20.70elapsed 787%CPU (0avgtext+0avgdata 853256maxresident)k
13200inputs+2504outputs (17major+1740758minor)pagefaults 0swaps
apache_beam/coders/coders_property_based_test.py:132:4: W0101: Unreachable code (unreachable)
apache_beam/coders/coders_property_based_test.py:133:4: W0101: Unreachable code (unreachable)
apache_beam/coders/coders_property_based_test.py:136:4: W0101: Unreachable code (unreachable)

not related to this change, and the file last modified 1 month ago. Not sure why it surfaced for this PR run

That lint failure started to pop up last night in master: https://github.com/apache/beam/actions/runs/19810292801

@Abacn
Copy link
Contributor

Abacn commented Dec 1, 2025

let's merge to fix precommit failures currently on head

@Abacn Abacn merged commit 0fb3736 into apache:master Dec 1, 2025
101 of 102 checks passed
shunping added a commit to shunping/beam that referenced this pull request Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants