Skip to content

Conversation

@derrickaw
Copy link
Collaborator

#35198

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @derrickaw, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request temporarily disables an extended YAML test related to data enrichment using BigQuery. The test pipeline has been commented out to mitigate a suspected race condition, allowing for further investigation into the underlying issue without impacting continuous integration stability. This is a temporary measure until a proper resolution can be implemented.

Highlights

  • Test Disablement: A specific Enrichment pipeline test within enrichment.yaml has been temporarily commented out.
  • Race Condition Mitigation: This action was taken to address a potential race condition identified in the test, pending further investigation and a permanent fix.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@derrickaw derrickaw changed the title [yaml] - comment out potential race condition until further investigation in enrichment test [yaml] - tmp fix for enrichment test Nov 26, 2025
@derrickaw derrickaw requested a review from shunping November 26, 2025 14:03
Copy link
Collaborator

@shunping shunping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@shunping shunping merged commit baa1751 into apache:master Nov 26, 2025
100 checks passed
@derrickaw derrickaw deleted the tmpFixEnrichmentTest branch November 26, 2025 14:59
@Amar3tto
Copy link
Collaborator

@shunping Should we cherry pick this to release branch?

@shunping
Copy link
Collaborator

This PR disabled a recently flaky test, which is also one of the release milestone. Let me cherry-pick it later today.

@shunping
Copy link
Collaborator

@shunping Should we cherry pick this to release branch?

Actually this PR has made the cut, so no extra cherry pick is needed.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants