Skip to content

Conversation

@claudevdm
Copy link
Collaborator

@claudevdm claudevdm commented Nov 19, 2025

Tests are failing https://github.com/apache/beam/actions/runs/19499862856/job/55811002383 because import was removed in #36732


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @claudevdm, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on enhancing the compatibility of Apache Beam's type hint conversion utility with newer Python versions, specifically Python 3.10 and later. It introduces version-specific checks to correctly interpret and convert advanced type hint constructs like types.UnionType and typing.NewType, ensuring robust type handling across different Python environments.

Highlights

  • Re-introduction of sys module import: The sys module has been re-imported into native_type_compatibility.py to facilitate version-specific checks.
  • Python 3.10+ compatibility for types.UnionType: Conditional logic has been added to the convert_to_beam_type function to specifically handle types.UnionType only when running on Python 3.10 or newer, addressing potential compatibility issues with the pipe operator for unions.
  • Python 3.10+ compatibility for typing.NewType: The handling of typing.NewType in convert_to_beam_type now includes a version check, applying specific logic only for Python 3.10 and above, where NewType changed from a function to a class.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@claudevdm
Copy link
Collaborator Author

R: @jrmccluskey
R: @tvalentyn

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

Copy link
Contributor

@jrmccluskey jrmccluskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, not sure how that got taken out!

@jrmccluskey jrmccluskey merged commit f5b4b6d into apache:master Nov 19, 2025
85 of 89 checks passed
@Abacn
Copy link
Contributor

Abacn commented Nov 19, 2025

Sounds strange though. This file no longer uses sys module, and the error stacktrace

 File "/runner/_work/beam/beam/sdks/python/apache_beam/typehints/native_type_compatibility.py", line 343, in convert_to_beam_type
    if sys.version_info >= (3, 12) and TypeAliasType is not None:

"native_type_compatibility" has imported sys.

yet lint does not complain

EDIT: sorry, never mind. I was confused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants