-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Bump Beartype bounds #36792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Beartype bounds #36792
Conversation
Summary of ChangesHello @jrmccluskey, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the version constraint for the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
|
assign set of reviewers |
|
Coverage failure is from a failure to start Docker-in-Docker, also red on master |
|
Assigning reviewers: R: @liferoad for label python. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
Reminder, please take a look at this pr: @liferoad |
|
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment R: @damccorm for label python. Available commands:
|
sdks/python/setup.py
Outdated
| 'zstandard>=0.18.0,<1', | ||
| 'pyyaml>=3.12,<7.0.0', | ||
| 'beartype>=0.21.0,<0.22.0', | ||
| 'beartype>=0.22.0,<0.23.0', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to be this tight on the bounds? Is there something specific we need in 0.22 in order to function?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general no, although this version jump from 0.21.0 to 0.22.0 did wind up changing the import paths of some subpackages (which we don't currently import directly, but could in the future.) I think for this jump I'd prefer to keep it tight as we incorporate beartype, then loosen the bounds slowly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think if we can be looser, we should. This is part of the core beam library which means that if anyone is relying on a package which enforces a different BearType version, they won't be able to install Beam naively. If it was an extra I'd feel differently, but if there are no known issues then I think we should be loose.
|
Reminder, please take a look at this pr: @damccorm |
|
waiting on author |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #36792 +/- ##
=============================================
+ Coverage 40.37% 57.04% +16.67%
Complexity 3476 3476
=============================================
Files 1226 1226
Lines 188407 188606 +199
Branches 3607 3607
=============================================
+ Hits 76063 107587 +31524
+ Misses 108946 77620 -31326
- Partials 3398 3399 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Slide Beartype bounds to hit current minor releases.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.