Skip to content

Conversation

@damccorm
Copy link
Contributor

This is only used by request response users who are using the hadoop file system, and it causes some users install issues, so there's no reason to bundle them into the main installable

Part of #34554


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions github-actions bot added the io label Nov 21, 2025
@codecov
Copy link

codecov bot commented Nov 21, 2025

Codecov Report

❌ Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 40.42%. Comparing base (9516397) to head (0d1563e).
⚠️ Report is 75 commits behind head on master.

Files with missing lines Patch % Lines
sdks/python/apache_beam/io/hadoopfilesystem.py 66.66% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #36773      +/-   ##
============================================
+ Coverage     40.28%   40.42%   +0.13%     
  Complexity     3457     3457              
============================================
  Files          1223     1226       +3     
  Lines        187539   187949     +410     
  Branches       3587     3587              
============================================
+ Hits          75546    75972     +426     
+ Misses       108601   108585      -16     
  Partials       3392     3392              
Flag Coverage Δ
python 40.76% <66.66%> (+0.33%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@damccorm damccorm marked this pull request as ready for review November 24, 2025 21:04
@github-actions
Copy link
Contributor

Assigning reviewers:

R: @claudevdm for label python.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link
Collaborator

@claudevdm claudevdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What test suite are the tests meant to run under now? I see they are skipeed in PreCommit and just want to sanity check that they are passing somewhere.

@damccorm
Copy link
Contributor Author

What test suite are the tests meant to run under now? I see they are skipeed in PreCommit and just want to sanity check that they are passing somewhere.

Thanks - good catch. They should run under coverage, but I typoed the extra name. Rerunning, but I think this should fix

@damccorm
Copy link
Contributor Author

damccorm commented Nov 26, 2025

Confirmed that this fixed the problem

image

Copy link
Collaborator

@claudevdm claudevdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like failing tests are unrelated.

@damccorm damccorm merged commit 7323fb8 into master Nov 26, 2025
105 of 114 checks passed
@damccorm damccorm deleted the users/damccorm/hadoopExtra branch November 26, 2025 20:53
damccorm added a commit that referenced this pull request Nov 26, 2025
* split hdfs into extra

* CHANGES

* tox

* try/catch

* test fixes

* add to coverage tasks
damccorm added a commit that referenced this pull request Nov 27, 2025
* split hdfs into extra (#36773)

* split hdfs into extra

* CHANGES

* tox

* try/catch

* test fixes

* add to coverage tasks

* Update CHANGES to mention extras changes (#36875)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants