-
Notifications
You must be signed in to change notification settings - Fork 4.5k
split hdfs into extra #36773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
split hdfs into extra #36773
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #36773 +/- ##
============================================
+ Coverage 40.28% 40.42% +0.13%
Complexity 3457 3457
============================================
Files 1223 1226 +3
Lines 187539 187949 +410
Branches 3587 3587
============================================
+ Hits 75546 75972 +426
+ Misses 108601 108585 -16
Partials 3392 3392
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Assigning reviewers: R: @claudevdm for label python. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
claudevdm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What test suite are the tests meant to run under now? I see they are skipeed in PreCommit and just want to sanity check that they are passing somewhere.
Thanks - good catch. They should run under coverage, but I typoed the extra name. Rerunning, but I think this should fix |
claudevdm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like failing tests are unrelated.
* split hdfs into extra * CHANGES * tox * try/catch * test fixes * add to coverage tasks

This is only used by request response users who are using the hadoop file system, and it causes some users install issues, so there's no reason to bundle them into the main installable
Part of #34554
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.