-
Notifications
You must be signed in to change notification settings - Fork 4.5k
[3/3] sdks/python: sink data with Milvus Search I/O connector #35944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[3/3] sdks/python: sink data with Milvus Search I/O connector #35944
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @mohamedawnallah, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request, part two of a two-part series, integrates the Milvus Search I/O connector into Apache Beam's Python SDK by adding comprehensive documentation and examples. It updates the official Beam documentation to include the Milvus sink, provides a Python example, adds the connector to the built-in catalog, and includes a Jupyter Notebook example for practical usage. This enhances the discoverability and usability of the Milvus connector for users working with vector databases in RAG workflows.
Highlights
- Documentation Addition: New documentation for the Milvus I/O connector has been added, detailing its features, usage, configuration options, and performance considerations for writing vector embeddings to Milvus.
- Catalog Integration: The Milvus I/O connector has been integrated into the Beam I/O Connectors Built-in Catalog, making it discoverable alongside other available connectors.
- Example Code: A comprehensive Python example demonstrating how to use the Milvus sink in a Beam pipeline, including connection and write configurations, has been added to the documentation.
- Jupyter Notebook Example: A Jupyter Notebook example (milvus_vector_ingestion_and_search.ipynb) has been provided to showcase practical usage of the Milvus Search Sink I/O connector for vector ingestion and search.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
|
Assigning reviewers: R: @kennknowles for label website. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
stop reviewer notifications EDIT: Till the upstream PR is merged |
|
Stopping reviewer notifications for this pull request: requested by reviewer. If you'd like to restart, comment |
|
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions. |
|
Waiting on the author |
Description
Depends on #35708.
Towards #35046.
Website Update Demo
Screen.Recording.2025-08-22.at.11.54.45.PM.mov
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.