Recommend yield from for emitting elements from iterables.
#25893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
R: @liferoad |
Contributor
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
liferoad
reviewed
Mar 18, 2023
| `return` statements in the same `process` method - this leads to [undefined behavior](https://github.com/apache/beam/issues/22969). | ||
| elements with `yield` statements, and use `yield from` to emit all elements from | ||
| an iterable, such as a list or a generator. Using `return` statement | ||
| with an iterable is also acceptable as long as you don't mix `yield` and |
Contributor
There was a problem hiding this comment.
yield could cause the this error cannot pickle 'generator' object for some cases. This is why I did not update the doc in #25743
Contributor
Author
There was a problem hiding this comment.
as discussed offline cannot pickle 'generator' object was happening in different contexts (outside of process methods). LMK if you think we should merge this, feel free to suggest a different wording.
liferoad
approved these changes
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up for https://github.com/apache/beam/pull/25060/files, relates to #22969.