AVRO-4234: [Java] Fix byte array JSON serialization in IdlUtils.#3666
Open
lw-mcno wants to merge 1 commit intoapache:mainfrom
Open
AVRO-4234: [Java] Fix byte array JSON serialization in IdlUtils.#3666lw-mcno wants to merge 1 commit intoapache:mainfrom
lw-mcno wants to merge 1 commit intoapache:mainfrom
Conversation
…me tests to match the project's convention.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Fixes AVRO-4234 where IDL formatting / output from schema doesn't work correctly for byte array default values.
Enables tests that were not running, because their names didn't follow the project's configured convention.
Verifying this change
This change added tests and can be verified as follows:
IdlUtilsTesttoTestIdlUtilsandIdlSchemaFormatterFactoryTesttoTestIdlSchemaFormatterFactory, so that they actually get found and executed during build.IdlUtilsTest- both java based and the IDL file used in tests also has a byte array default value now.Documentation