java-[key-]class allowed packages must be packages #3453
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opwvhk
force-pushed
the
allowed-packages-must-be-backages
branch
from
c935d51 to
f2609c6
Compare
opwvhk
added a commit
to opwvhk/avro
that referenced
this pull request
Sep 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
SpecificDatumReader.SERIALIZABLE_PACKAGESwas used as a list of class name prefixes instead of the package names it is designed as. This change forces the provided package names to be package names.Verifying this change
This change is a near-trivial refactoring without any test coverage.
Tests should be added, but this is a larger undertaking than a quick fix.
Documentation
yes/ no)docs / JavaDocs / not documented)