Avro-4169: [java] custom encoder bug #3440
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@opwvhk had an oversight hidden by having the identical schema to its generated class. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
lang/java/avro/src/test/java/org/apache/avro/reflect/TestAvroEncode.java
Dismissed
Show dismissed
Hide dismissed
opwvhk
pushed a commit
to opwvhk/avro
that referenced
this pull request
Sep 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Fixes a bug where, if the custom encoder is specified at the top of the class, it did not drive the schema used.
This updates a test to ensure the schema used is not the same as what would be used by reflection, highlighting this issue.
Verifying this change
This change added tests and can be verified as follows:
extends test to make sure this case is covered.
Documentation