AVRO-4163: [java] add java 17 test module. #3424
Conversation
lang/java/pom.xml
Outdated
| <pluginExecutionFilter> | ||
| <groupId>com.diffplug.spotless</groupId> | ||
| <artifactId>spotless-maven-plugin</artifactId> | ||
| <versionRange>[0,)</versionRange> |
There was a problem hiding this comment.
This change is not related to the PR.
I'd prefer to be in a separate PR but the Java team might be OK...
There was a problem hiding this comment.
Done.
Will move to standalone PR
lang/java/pom.xml
Outdated
| <pluginExecutionFilter> | ||
| <groupId>org.apache.maven.plugins</groupId> | ||
| <artifactId>maven-plugin-plugin</artifactId> | ||
| <versionRange>[0,)</versionRange> |
| assertEquals("test used this", read.getR1().value()); | ||
| } | ||
|
|
||
| public static class Wrapper { |
There was a problem hiding this comment.
Why is this class needed ?
Isn't it possible to put @AvroEncode(using = R1Encoding.class) directly on the record class itself ?
Disclaimer: I haven't used Java (in general, not only the Avro Java SDK) for several years now.
There was a problem hiding this comment.
Ah, I see it in your other PR - https://github.com/apache/avro/pull/3425/files#diff-6f4c55d40c67ca00b539c805c113311a15f5bf8c14a85b56e58d1c8f57392a89R33
PR feedback
|
@martin-g made suggestions. Is there anyone I should ping to review the Java side? |
* AVRO-4163: add java 17 test module. * mis click * remove changes from pom.xml PR feedback
3 participants
This pull request adds Java 17 test support.
This will allow adding support for features like Java records without requiring an update to the Maven build.
This change added tests and can be verified as follows:
This adds a test that if a
@AvroEncodeis specified on a Java record, it works correctly.