AVRO-4159 [Java]: complete support for duration #3416
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-g
approved these changes
Jun 27, 2025
opwvhk
added a commit
that referenced
this pull request
Jun 27, 2025
Contributor
Author
|
Cherry-picked to 1.12.1 |
opwvhk
added a commit
to opwvhk/avro
that referenced
this pull request
Sep 5, 2025
* AVRO-4159: Add duration logical type to switch statement * AVRO-4159: Improve TimePeriod javadoc * AVRO-4159: Also test for support by type name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Support for the duration logical type was missing the final bit: recognising the logical type name in the switch statement in
LogicalTypes(documented as bug AVRO-4159). This fixes that.Verifying this change
This change updated a test:
org.apache.avro.TestLogicalType#durationExtendsFixed12Documentation
yes/ no)docs / JavaDocs / not documented)