AVRO-4153: add netty-codec #3405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opwvhk
commented
Jun 11, 2025
lang/java/ipc-netty/src/test/java/org/apache/avro/ipc/netty/TestNettyServerWithCompression.java
Show resolved
Hide resolved
nandorKollar
approved these changes
Jun 11, 2025
Contributor
nandorKollar
left a comment
nandorKollar
left a comment
There was a problem hiding this comment.
Wondering how come that a patch release from Netty causes such a problem in Avro. it is supposed to include only fixes, but it seems it also reorganised modules? Nevertheless, if tests finally pass, then LGTM.
Contributor
Author
|
Yes, it's weird. My assumption is that it has to do with the combination of the module system and tests (the package |
opwvhk
added a commit
that referenced
this pull request
Jun 13, 2025
opwvhk
added a commit
that referenced
this pull request
Jun 14, 2025
opwvhk
added a commit
to opwvhk/avro
that referenced
this pull request
Sep 5, 2025
* AVRO-4153: Add dependency to netty-codec * AVRO-4153: Upgrade netty to 4.2.2.Final
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Add a dependency to
netty-codecin order to allow upgrading.Verifying this change
This change can be verified as follows:
Documentation
yes/ no)docs / JavaDocs / not documented)