Skip to content

Conversation

@opwvhk
Copy link
Contributor

@opwvhk opwvhk commented Jun 11, 2025

What is the purpose of the change

Remove the signature files from the shaded tools jar. These have the tendency to break (become invalid) in shaded jars.

Verifying this change

  1. Check the failed build pipelines for the dependabot PR to upgrade Hadoop to 3.4.1
  2. Compare its change to this PR
  3. Check the build pipelines for this PR

This change is a trivial rework / code cleanup without any test coverage.

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

opwvhk added 2 commits June 11, 2025 12:38
This tests the signature removal: without the change, the build will
fail (as seen with the dependabot pipelines).
@github-actions github-actions bot added Java Pull Requests for Java binding build labels Jun 11, 2025
@opwvhk opwvhk merged commit 8d1b139 into apache:main Jun 11, 2025
9 checks passed
@opwvhk opwvhk deleted the AVRO-4152-remove-signatures-from-shaded-tools-jar branch June 11, 2025 11:10
opwvhk added a commit that referenced this pull request Jun 13, 2025
* AVRO-4152: Remove signatures from shaded jar

* AVRO-4152: Upgrade Hadoop to 3.4.1

This tests the signature removal: without the change, the build will
fail (as seen with the dependabot pipelines).

(cherry picked from commit 8d1b139)
opwvhk added a commit that referenced this pull request Jun 14, 2025
* AVRO-4152: Remove signatures from shaded jar

* AVRO-4152: Upgrade Hadoop to 3.4.1

This tests the signature removal: without the change, the build will
fail (as seen with the dependabot pipelines).

(cherry picked from commit 8d1b139)
opwvhk added a commit to opwvhk/avro that referenced this pull request Sep 5, 2025
* AVRO-4152: Remove signatures from shaded jar

* AVRO-4152: Upgrade Hadoop to 3.4.1

This tests the signature removal: without the change, the build will
fail (as seen with the dependabot pipelines).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Java Pull Requests for Java binding

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant