AVRO-4139 [java] fix equality check for maps in arrays #3378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the introduction of the `AbstractArray` in avro 1.12, it was not possible anymore to compare arrays which contained objects which contained a Map, as the fact that we compared for equality was not propagated anymore. This commit re-introduces this propagation.
steven-aerts
changed the title
opwvhk
approved these changes
May 29, 2025
opwvhk
pushed a commit
that referenced
this pull request
Jun 13, 2025
With the introduction of the `AbstractArray` in avro 1.12, it was not possible anymore to compare arrays which contained objects which contained a Map, as the fact that we compared for equality was not propagated anymore. This commit re-introduces this propagation. (cherry picked from commit a651bb2)
opwvhk
pushed a commit
to opwvhk/avro
that referenced
this pull request
Sep 5, 2025
With the introduction of the `AbstractArray` in avro 1.12, it was not possible anymore to compare arrays which contained objects which contained a Map, as the fact that we compared for equality was not propagated anymore. This commit re-introduces this propagation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the introduction of the
AbstractArrayin avro 1.12, it was not possible anymore to compare arrays which contained objects which contained a Map, as the fact that we compared for equality was not propagated anymore.This commit re-introduces this propagation.
Verifying this change
This change added an unit test
Documentation